Let's talk about games with GREAT weapon selections that actually feels diverse and unique and have good upgrading/leveling/customization capabilities. Also the crazier the weapons, the better. Pic related is basically porn to me.
Good examples:
>Ratchet & Clank
>Dark Souls
>Terraria
Bad examples:
>Borderlands
>Nioh
>90% of all MMOs